Regenerate catalog editor-charts and image scripts#1302
Merged
Conversation
Populate catalog/editor-charts.yaml with the editor charts (v0.36.0) resolved by image-packer list-editor-charts and regenerate the derived copy/export/import image scripts. Fixes the verify-catalog CI failure. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
image-packer embeds the resource-metadata hubs, but the reloader used by kmodules.xyz/resource-metadata shadows the embedded copies with /tmp/hub/<hub> when those directories exist. A stale or empty leftover there makes image-packer load nothing and emit a broken catalog, so remove /tmp/hub before running. The underlying reloader flaw is fixed upstream in gomodules.xyz/x (gomodules/x#71); this guards catalog generation until that lands and re-vendors. Signed-off-by: Tamal Saha <tamal@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verify-catalogCI check on master is failing becausecatalog/editor-charts.yamlis committed as[]whileimage-packer list-editor-chartsresolves 145 editor charts (v0.36.0) across theautoscaling.kubedb.com,kubedb.com,ops.kubedb.com,*.kubestash.comandcharts.x-helm.devAPI groups.This regenerates:
catalog/editor-charts.yaml— populated with the 145 editor chartscatalog/{copy,export,import}-images.shandcatalog/import-into-k3s.sh— the derived image scripts now including the editor imagesGenerated via
./hack/scripts/update-catalog.sh(image-packer list-editor-charts+generate-scripts, then license + shfmt). Output is byte-identical to the CI regeneration.Fixes the failure in https://github.com/appscode-cloud/installer/actions/runs/29233685263